Repository navigation
ci: backport real-TLS status tolerance and conventional-commit rerun fix to 8.x - #1580
Merged
Merged
Conversation
…fix to 8.x Backport of #1576 and the conventional-commit rerun part of #1550. - test_real_tls_handshake_still_validates_hostname accepts any HTTP status: a response proves the handshake and hostname check passed, and example.com intermittently answers 503. - The conventional-commit policy re-fetches the PR title and body instead of trusting the rerun's stale webhook payload, and refuses to validate if the PR head moved. The job gets GH_TOKEN and pull-requests: read. The row-storage and export-snapshot parts of #1550 are not taken; 8.x has no reporting/ledger/row_storage.py. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean backport to release/8.x with no blocking or medium findings.
Checked:
- Backport of #1576 (TLS test status tolerance) and the conventional-commit rerun fix from #1550.
conventional()re-fetches PR title/body via the API under the existing 30surlopentimeout; therequire(current["head"]["sha"] == pr["head"]["sha"], ...)guard is fail-closed (a rerun on a moved head refuses rather than validating stale commits).- Dispatch wiring (
GH_TOKEN,pull-requests: read) present in ci.yml and asserted by the new tests; all four tests use existing helpers. - No public adcp.* surface, generated code, credentials, forward-compat, or import-layering concerns. CI gates remain armed.
No author team gate, no gated paths, high_risk false. Rows 1–8 do not fire; falls through to row 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #1576 and the conventional-commit rerun fix from #1550 to
release/8.x. Both make 8.x CI more stable before 8.2.0 is cut.test_real_tls_handshake_still_validates_hostnamenow accepts any HTTP status (100 <= status < 600). Getting a response at all shows the handshake and hostname check passed, because a certificate mismatch raises before any response exists. The test isn't checking the origin's own status, and example.com sometimes answers 503.scripts/check_main_policies.pynow fetches the current title and body from the API. If the PR head has moved, it refuses withPR head changed; run current CI, so a rerun can't validate commits it didn't check out. The job inci.ymlgetsGH_TOKENandpull-requests: read.Not taken from #1550
The row-storage readiness change, its Postgres conformance test, the export-resolution tweak and the public API snapshot additions. 8.x has no
reporting/ledger/row_storage.py.Tests
tests/test_main_release_policies.py: a rerun reads the corrected body; a rerun rejects a body that has become invalid; a moved head is refused; the workflow job has the permission and token.tests/test_main_release_policies.pyandtests/conformance/signing/test_ip_pinned_transport.py: 82 passed.make lintandmake typecheck-allpass. Full suite: 12992 passed, 2434 skipped, 1 xfailed.🤖 Generated with Claude Code
Open workspace in Conductor