Skip to content

test(release): accept next's storage version in the storage manifest check #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
Oct 27, 2026
Merged

test(release): accept next's storage version in the storage manifest check #1675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/test_release_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,15 @@ def test_storage_distribution_version_matches_its_manifest_entry() -> None:
)
assert project_section is not None
manifest = json.loads((ROOT / ".release-please-manifest.json").read_text())
assert project_section.group(1) == pep440_prerelease(
manifest["packages/adcp-reporting-storage"]
)
expected = {pep440_prerelease(manifest["packages/adcp-reporting-storage"])}
# On next, the storage package releases its own 0.2.0-beta.N line from
# next's manifest, like the root package does in the test above.
next_manifest = ROOT / ".release-please-manifest.next.json"
if next_manifest.exists():
next_versions = json.loads(next_manifest.read_text())
if "packages/adcp-reporting-storage" in next_versions:
expected.add(pep440_prerelease(next_versions["packages/adcp-reporting-storage"]))
assert project_section.group(1) in expected
config = json.loads((ROOT / "release-please-config.json").read_text())
package = config["packages"]["packages/adcp-reporting-storage"]
assert package["component"] == package["package-name"] == "adcp-reporting-storage"
Expand Down
Loading