Conversation
New high-severity advisories for undici (via miniflare) put every Wrangler release from 4.16.0 through 4.130.0 in the vulnerable range, so CI's `npm audit --audit-level=high` step fails on both the previous pin (4.114.0) and PR #13's 4.127.1. Wrangler 4.136.3 is npm's remediation target and audits clean; the toolchain contract test pins the new version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0112H6AesYWoaS2XdDEHUJ4b
Owner
Author
|
Closing as superseded by #13. Its head ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's
npm audit --audit-level=highstep now fails onmain. New high-severityundiciadvisories (pulled in throughminiflare) put every Wrangler release from 4.16.0 through 4.130.0 in the vulnerable range:npm audit --audit-level=highmain(Wrangler 4.114.0)This PR pins Wrangler 4.136.3, the version npm recommends as the fix, and updates the toolchain contract test in
tests/test_app.pyto match.Stacked on #13. This branch is built on #13's head, so until #13 merges, the diff also shows its two commits. Once #13 is in
main, only theUpgrade Wrangler to 4.136.3commit remains.Verification
Run locally on Node 22.22.2 / Python 3.13 after a clean
npm ci --ignore-scriptsanduv sync --locked --all-groups, withpywrangler dev --port 9696running on Wrangler 4.136.3:make verify: every step passed exceptbrowser-layout-test(see below). That includes 225 unit tests, SEO/cache lint,verify-examples, all quality checks,search-ranking-test,lintandcheck-generated.scripts/format_examples.py --checkmake verify-python-version VERSION=3.13(109 examples verified)git diff --checknpm audit --audit-level=high: 0 vulnerabilitiesmake smoke-deployment URL=http://localhost:9696passed 9 GETs and 5 Dynamic Worker POST runs, including the edited-code, async, networking-boundary and subprocess-boundary runs.browser-layout-testfails locally on two checks, "Search focus indicator is too weak" and "CodeMirror focus indicator is too weak". The same two checks fail with #13's Wrangler 4.127.1, which passes CI, so the cause is the sandbox's Playwright Chromium build rather than this change. This PR changes no CSS or page code. CI runs the check with Google Chrome.🤖 Generated with Claude Code
https://claude.ai/code/session_0112H6AesYWoaS2XdDEHUJ4b