docs: Simplify logs in example - #386
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
benbrandt
changed the title
benbrandt
marked this pull request as ready for review
October 2, 2026 14:59
benbrandt
enabled auto-merge (squash)
October 2, 2026 14:59
benbrandt
disabled auto-merge
October 2, 2026 14:59
benbrandt
enabled auto-merge (squash)
October 2, 2026 14:59
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/agentclientprotocol/rust-sdk/security/code-scanning/6
General fix: avoid logging sensitive or untrusted dynamic values directly. Prefer constant log messages or redact/anonymize values before logging.
Best fix here (without changing behavior): keep the cancellation log, but remove
request.session_idinterpolation from theeprintln!call. The request handling and response remain unchanged; only the logged content is sanitized.Edit in
src/agent-client-protocol/examples/v2_one_shot_client.rs, around lines 56–59, replacing the formatted message that includes{}andrequest.session_idwith a static message.No new imports, helper methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.