Repository navigation
fix(sdk): enforce exporter isolation at send time for OTel 1.45 - #277
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTelemetry 1.45 changed how the OTLP HTTP exporters resolve settings: headers from
OTEL_EXPORTER_OTLP_*HEADERSare now merged with explicit ones, and the client certificate from the environment is set on the requests session. As a result the SDK sent the application's OTLP headers and mTLS certificate to the agentevals endpoint, or dropped exports when those certificate files were missing.The SDK's isolated session now enforces isolation in
send(): default trust store, no client certificate, no proxy, and only transport headers plusx-agentevals-sdk. This works on 1.44 and 1.45.TestExporterIsolationnow checks the outgoing request at the HTTP adapter instead of private exporter attributes, and passes on both versions. Unblocks #276.