Repository navigation
fix(telemetry): close tuple privacy bypass, reject array AgenTrust headers in TS propagation, and validate digests in TRACE finalization - #102
Conversation
…S propagation, and validate digests in TRACE finalization Closes agentrust-io#101 Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com> Co-authored-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
dinakarjs
left a comment
There was a problem hiding this comment.
Reviewed exact head 4f42131 (full commit attached). Checked tuple traversal for privacy/JSON-shape checks, duplicate-member schema/fixture parsing, digest validation and TypeScript propagation/header refusal. With hash-locked Python test dependencies, all 165 unittest cases and conformance validation passed. TypeScript build passed and all 46 tests passed using node --import tsx --test test/*.test.ts (the tsx CLI IPC socket is unavailable here). The first Python run inherited a host 1% OTel sampler; clearing OTEL_TRACES_SAMPLER/ARG resolved the three sampling-dependent failures, which also reproduced on main. Hosted CI/CodeQL/fuzz are still action_required, so this is a source/local-test approval and does not claim hosted validation.
rajnisht7
left a comment
There was a problem hiding this comment.
the overall changes looks good, a few things needs to be addressed:
- Digest tests - Python suite tests trailing newline (sha256:…\n). TS regex rejects it too, but the new test matrix doesn’t cover it, add the same case for both buildDigest and policy bundle_digest.
- extractContext wording -The changelog/PR says “carrier headers”, but the code only validates the three AgenTrust headers (run-id, workflow-id, agent-id). OTel headers (traceparent etc.) are still passed through, matching Python, kindly narrow the wording to “AgenTrust carrier headers” so the claim matches the implementation.
…ildDigest and policy.bundle_digest Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Thanks @rajnisht7! Added trailing-newline ( |
Summary
Closes #101
Contract impact
Evidence
pm --prefix packages/typescript run check (passed: 46 TypeScript tests passed, sc build and
pm pack --dry-run succeeded)
Privacy and security
Limits
Validates digest syntax and JSON/container shapes in Python and TypeScript SDKs; does not alter the JSON Schema wire contract or cryptographic verification semantics in ^Ggentrust-trace.