Repository navigation
Conversation
…tion in Python AGT adapters (agentrust-io#106) - Validate evaluation_duration_ns, duration_ns, and _audit_duration against bool and 0 <= value <= 2**53 - 1 in Python agt_approval.py and agt_audit.py. - Validate bundle_digest and action_digest against sha256/sha384 lowercase hex in agt_policy_decision_record, agt_audit_policy_decision, and agt_audit_action. Closes agentrust-io#106 Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
dinakarjs
left a comment
There was a problem hiding this comment.
Reviewed source at 029238b. Python unittest discovery passed with inherited OTEL_* variables removed; the initial three OTel failures were environment configuration. TypeScript build and all 44 existing tests passed using node --import tsx --test test/*.test.ts; the npm check launcher itself encountered an IPC-listen EPERM here, so I do not claim that wrapper passed. Local results only, not hosted CI. Python: 159 tests pass.
The new combined test exercises the approval adapter, while this PR also changes agt_audit. Please add independent agt_audit duration/digest regressions, including a valid SHA-384 digest and valid boundary durations, and show each added refusal fails when only that guard is disabled. A passing aggregate suite does not establish coverage of every new predicate.
Source review and local validation are complete within this scope; regression coverage remains for author follow-up before approval.
Prepared with OpenAI Codex.
… regressions Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Thanks @dinakarjs! Added independent |
Summary
evaluation_duration_ns,duration_ns, and_audit_durationagainstbooland0 <= value <= 9007199254740991(2**53 - 1) insrc/agentrust_telemetry/adapters/agt_approval.pyandsrc/agentrust_telemetry/adapters/agt_audit.py.bundle_digestandaction_digestagainstsha256(64 lowercase hex) /sha384(96 lowercase hex) inagt_policy_decision_record,agt_audit_policy_decision, andagt_audit_action.Closes #106
Validation
python -m pytest tests/test_agt_approval.py tests/test_agt_audit.py -qpython -m ruff check src/agentrust_telemetry/adapters/agt_approval.py src/agentrust_telemetry/adapters/agt_audit.py tests/test_agt_approval.py