Repository navigation
fix(factory,agt-approval,agt-audit): preserve explicit empty event_id/instance_id for validation and reject pre-epoch timestamps in TS (#115) - #120
Open
drk-ram wants to merge 1 commit into
Conversation
…/instance_id for validation and reject pre-epoch timestamps in TS (agentrust-io#115) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Summary
event_id is Noneinstead ofevent_id or ...in PythonEventFactory.build(src/agentrust_telemetry/adapters/base.py) so an explicitevent_id=""fails validation instead of silently generating a random UUID.None/undefinedproducer_instance_id/producer.instanceIdin Python (base.py) and TypeScript (packages/typescript/src/factory.ts) so""fails schema validation.< 1970-01-01T00:00:00Z) timestamps inpackages/typescript/src/agt-approval.tsandpackages/typescript/src/agt-audit.ts.tests/test_adapters.py,packages/typescript/test/agt-approval.test.ts, andpackages/typescript/test/agt-audit.test.ts.Validation
pytest tests/test_adapters.py -q— passed (23 passed)