Repository navigation
fix(aeoess-aps): enforce exact int max_age_seconds/clock_skew_seconds and datetime reference_time in verify_aps_action_receipt (#376) - #381
Conversation
… and datetime reference_time in verify_aps_action_receipt (agentrust-io#376) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
carloshvp
left a comment
carloshvp
left a comment
There was a problem hiding this comment.
Reviewed exact head 9d50c964a1860bd32511d4dab6eb5c54a36debee in an isolated checkout.
Receipt verification now validates timezone-aware datetime inputs and exact non-negative integer age/skew settings before evaluating the receipt, with controlled handling of malformed action bindings. All 92 integration tests pass against the repository's fixed released-package lock, including signed receipt controls. The six focused window-boundary regressions fail when the actual baseline helper is restored in process. pip check, repository CI Ruff and diff whitespace checks pass. No blocking finding; hosted checks and maintainer policy remain separate.
Reviewed with OpenAI Codex.
Closes #376
Summary
isinstance(reference_time, datetime)andtype(max_age_seconds) is int and type(clock_skew_seconds) is intinverify_aps_action_receipt.isinstance(action, dict)andaction.get("agent_id")before comparing againstreceipt["subject_agent"].integrations/aeoess-aps/tests/test_action_receipt.py.Validation
pytest integrations/aeoess-aps/tests/test_action_receipt.py -q— passed