Skip to content

fix(sovereign-agent-connector): reject boolean GCP claims, invalid validity_seconds, and non-canonical base64url signatures (#379) - #384

Open
drk-ram wants to merge 1 commit into
agentrust-io:mainfrom
drk-ram:drk-ram-fix-auc-379
Open

drk-ram wants to merge 1 commit into
agentrust-io:mainfrom
drk-ram:drk-ram-fix-auc-379

Conversation

@drk-ram

@drk-ram drk-ram commented Oct 25, 2026

Copy link
Copy Markdown

Closes #379

Summary

  • Reject boolean iat, exp, and instance_id (and empty instance_id) in make_gcp_placement_assertion.
  • Validate type(validity_seconds) is int and validity_seconds > 0 and canonical 64-char lowercase hex workload_key across make_placement_assertion, make_azure_placement_assertion, and make_gcp_placement_assertion.
  • Enforce canonical unpadded 64-byte base64url signatures and 64-char lowercase hex trusted_key_hex in agentrust_auc.core._unb64 and _verify_signed.
  • Add unit tests in examples/sovereign-agent-connector/tests/test_appraisal.py.

Validation

  • pytest examples/sovereign-agent-connector/tests/test_appraisal.py -q — passed (14 passed)

…lidity_seconds, and non-canonical base64url signatures (agentrust-io#379)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com>
@drk-ram
drk-ram requested review from a team, carloshvp and imran-siddique as code owners October 25, 2026 07:00
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Contributor Check: MEDIUM

Check Result
Profile MEDIUM
Credential LOW
Overall MEDIUM

Automated check by AgenTrust Contributor Check.

@github-actions github-actions Bot added the needs-review:MEDIUM Contributor check flagged MEDIUM risk label Oct 25, 2026

@carloshvp carloshvp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head c17d8244b79cda2624fc6477ce0a4ceeff8f0970 in an isolated checkout.

The software example rejects boolean GCP numeric claims, invalid validity intervals, malformed public-key hex and noncanonical/wrong-length signatures, while preserving the valid signed placement/appraisal controls. All 53 example tests pass; the focused control fails with the baseline appraisal/core modules restored. I resolved the example's declared requirements into a fresh local hash lock; pip check, scoped example/repository Ruff and diff whitespace checks pass. Operator placement assertions, verified token claims and hardware evidence remain separate. No blocking finding in the changed example; hosted CI and maintainer policy remain separate.

Reviewed with OpenAI Codex.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review:MEDIUM Contributor check flagged MEDIUM risk

Projects

None yet

2 participants