Repository navigation
fix(sovereign-agent-connector): reject boolean GCP claims, invalid validity_seconds, and non-canonical base64url signatures (#379) - #384
Conversation
…lidity_seconds, and non-canonical base64url signatures (agentrust-io#379) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Raghuvar Durga <177662415+drk-ram@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
carloshvp
left a comment
There was a problem hiding this comment.
Reviewed exact head c17d8244b79cda2624fc6477ce0a4ceeff8f0970 in an isolated checkout.
The software example rejects boolean GCP numeric claims, invalid validity intervals, malformed public-key hex and noncanonical/wrong-length signatures, while preserving the valid signed placement/appraisal controls. All 53 example tests pass; the focused control fails with the baseline appraisal/core modules restored. I resolved the example's declared requirements into a fresh local hash lock; pip check, scoped example/repository Ruff and diff whitespace checks pass. Operator placement assertions, verified token claims and hardware evidence remain separate. No blocking finding in the changed example; hosted CI and maintainer policy remain separate.
Reviewed with OpenAI Codex.
Closes #379
Summary
iat,exp, andinstance_id(and emptyinstance_id) inmake_gcp_placement_assertion.type(validity_seconds) is int and validity_seconds > 0and canonical 64-char lowercase hexworkload_keyacrossmake_placement_assertion,make_azure_placement_assertion, andmake_gcp_placement_assertion.trusted_key_hexinagentrust_auc.core._unb64and_verify_signed.examples/sovereign-agent-connector/tests/test_appraisal.py.Validation
pytest examples/sovereign-agent-connector/tests/test_appraisal.py -q— passed (14 passed)