Repository navigation
examples-ci: install pyOpenSSL for the model-signing demo - #386
pavancharak wants to merge 1 commit into
Conversation
carloshvp
left a comment
carloshvp
left a comment
There was a problem hiding this comment.
Reviewed exact head 98f36f8568004330ca1104a27dec2c5face99b98 in an isolated checkout.
The one-line pyOpenSSL installation is consistent with the directly imported dependency. I independently compared this head with #362 at e3c8dc2: the executable workflow is identical after removing explanatory comments. Pinned actionlint 1.7.12 and whitespace validation pass on this isolated head; local external ShellCheck/pyflakes integrations were unavailable. The current hosted weight-custody-manifest demo/test job also passes.
This is duplicate delivery of the existing narrow repair in #362, which includes the upstream model-transparency#685 explanation and already has current-head maintainer approvals, 30 successful checks and one intentional skip. Please consolidate this duplicate with #362 before merging. The broader requirements/README/LoRA follow-up remains with #360. This comment records the technical comparison and consolidation action.
Reviewed with OpenAI Codex.
The weight-custody-manifest job fails on a clean runner with ModuleNotFoundError: No module named 'OpenSSL'. The [model-signing] extra doesn’t install pyOpenSSL, and model_signing imports it. I reproduced the failure in a fresh virtualenv and confirmed installing pyOpenSSL fixes it. The change is one line in .github/workflows/examples-ci.yml.