Repository navigation
bench: add a prepared literal-range patch reference - #96
Draft
gspark-etri wants to merge 5 commits into
Draft
gspark-etri wants to merge 5 commits into
gspark-etri wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare admitted in-place materialization with a sound prepared literal patch under a common file-readiness contract. The reference already preserves same-offset bytes; the experiment tests the actual executor tradeoff instead of attributing that operation uniquely to the materializer.
The stdlib reference and public legacy-diff adapter bind input/diff/keep/source/manifest identities and verify kept bytes. The new cohort freezes input/store/cache/patch/driver/build-receipt pins, uses private same-filesystem donor copies and charges preparation. R verifies the full base, invokes the actual admitted driver and syncs/full-hashes its private output; L runs the actual patch CLI with its corresponding checks. Both require donor-inode transfer and exclusively publish the verified target. A separate full-SHA audit follows the timed endpoint. Actual initialization and validation costs remain charged. External build/host attestation is still required.
An excluded RL smoke gates five paired blocks RL/LR/RL/LR/RL. Main rechecks the pinned smoke's actual method, identity, clock and inode witnesses. A failed attempt stops the matrix without retry or valid-subset aggregate. Success-data cleanup is frozen, runs only after the audit, and removes guarded private child directories while retaining raw logs/results. Existing origin/cache layout is admitted read-only before any driver call, preventing a mistyped immutable input directory from gaining backend directories. Model mode accepts only the preregistered complete directed decode pair on Linux; fixtures cannot be relabeled as model evidence.
Validation: head 7726500, base e1b29c7, tested merge 8b134aa. CI41556702186 passes all three jobs; complete decoded logs were retained and checked. Go fmt/vet/race/build,77 existing CPU/evidence checks,39 reference/cohort checks and both actual S3 suites/roundtrips pass. The Go integration actually performs R/L smoke and all five synthetic paired blocks with full target audits. Local Windows:37pass+2explicit Go integration skips. Important origin-mutation feedback has observed RED→GREEN regression and independent recheck; no remaining Important issue in the bounded review.
Earlier CI41551086659's unchanged causal trace-parser failure remains retained and unresolved. No parser/core change or retry-to-green fix is claimed. The separate retained synthetic diagnostic traces are new evidence and do not replace that earlier missing trace.
Benchmark only: no node/controller call, accelerator allocation, installation or production/runtime modification. Prepared raw literals are not codec-matched storage controls. Origin data and earlier measured sources remain unchanged. Real-model R/L timing: not_run. Keep draft/unmerged until actual admitted smoke/main and raw replay are available.
Refs #95.