Repository navigation
feat(setup): project folder, media verify step, presets in UI/URL, ChatGPT app label - #4
Closed
seungwonme wants to merge 2 commits into
Closed
seungwonme wants to merge 2 commits into
seungwonme wants to merge 2 commits into
Conversation
Member
Author
|
Scope reduced by owner; only the quoting fix is kept in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3. #3 was merged before the project folder / verify / preset commit was pushed, so this PR carries that commit onto main. (The yt-dlp
--skip-dependenciesoption and the Windows helper pruning already landed in #3.)Summary
Documents/<name>; an existing folder is never overwritten (<name>-YYYYMMDD, or skip with a message). No downloaded file is executed. Folder names: letters, digits,.,_,-.ffmpeg -filtersmust containdrawtext, ending with "ChatGPT 앱을 완전히 종료한 뒤 다시 열어 주세요". The.batstays ASCII-only: Korean is emitted as\uXXXXescapes decoded by PowerShell (KR). macOS uses plain UTF-8 Korean.?os=win&preset=video-class&project=<zip>&name=<folder>[&sha256=]; copy-link emits the short form when the selection matches a preset.codex-appid is unchanged. Windows label "ChatGPT desktop app (includes Codex)" / "ChatGPT 데스크톱 앱 (Codex 포함)" (Store9PLM9XGG6VKS); macOS UI keeps "Codex App".Notes
[Environment]::GetFolderPath('MyDocuments')(fallback%USERPROFILE%\Documents).Verification
pnpm test,pnpm build,pnpm test:e2e(10 tests) pass.Security fix (automated review finding)
ps()now doubles ASCII'and the typographic single quotes U+2018, U+2019, U+201A, U+201B, which PowerShell also treats as quote delimiters. This covers every free-text setting, not only the project fields.https://plus RFC 3986 characters only (no quotes of any kind, backticks, spaces, backslashes, braces, non-ASCII), folder name^[A-Za-z0-9][A-Za-z0-9._-]{0,63}$, SHA-256 64 hex digits or empty. Invalid values omit the step entirely and the UI shows an error (role="alert"). An empty URL ignores the other fields.sh()single-quote escaping was already sound (bash only treats ASCII'specially) and is now also behind the validation.https://x/a’;calc;’, curly-quote names,;,$(calc), backticks, spaces, newlines, non-ASCII, plus an e2e test on a crafted shared link.