Repository navigation
fix(setup): double typographic single quotes in PowerShell quoting - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ps()only doubled the ASCII single quote. PowerShell also treats U+2018, U+2019, U+201A and U+201B as single-quote delimiters, so a value containing one of them (for example the Git name/email fields, which can come from a shared link) could end its quoted string and inject commands into the generated script.Fix
ps()now doubles all of' ‘ ’ ‚ ‛. Nothing else changes.Tests
tests/windows.test.js: a payload likea’;calc;’ …stays inside the quoted-Nameargument, and each of the five quote characters is doubled.The new assertions fail on current main and pass with the fix.
Verification
pnpm test,pnpm build,pnpm test:e2e(7 tests) pass. The video-class Windows script generated from this branch is byte-identical to main's (SHA-256 unchanged).Merge deploys the public site: needs owner approval.