Skip to content

fix(setup): double typographic single quotes in PowerShell quoting - #5

Merged
seungwonme merged 1 commit into
mainfrom
fix/ps-typographic-quotes
Nov 15, 2026
Merged

seungwonme merged 1 commit into
mainfrom
fix/ps-typographic-quotes

Conversation

@seungwonme

Copy link
Copy Markdown
Member

Problem

ps() only doubled the ASCII single quote. PowerShell also treats U+2018, U+2019, U+201A and U+201B as single-quote delimiters, so a value containing one of them (for example the Git name/email fields, which can come from a shared link) could end its quoted string and inject commands into the generated script.

Fix

ps() now doubles all of ' ‘ ’ ‚ ‛. Nothing else changes.

Tests

tests/windows.test.js: a payload like a’;calc;’ … stays inside the quoted -Name argument, and each of the five quote characters is doubled.
The new assertions fail on current main and pass with the fix.

Verification

pnpm test, pnpm build, pnpm test:e2e (7 tests) pass. The video-class Windows script generated from this branch is byte-identical to main's (SHA-256 unchanged).

Merge deploys the public site: needs owner approval.

@seungwonme
seungwonme merged commit 521cb03 into main Nov 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant