Skip to content

ci(workflows): remove the CodeQL analysis - #218

Merged
tobi-ax merged 2 commits into
mainfrom
ci/TSSDK-84-remove-codeql
Nov 19, 2026
Merged

tobi-ax merged 2 commits into
mainfrom
ci/TSSDK-84-remove-codeql

Conversation

@tobi-ax

@tobi-ax tobi-ax commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Jira: TSSDK-84, part of TSSDK-83

The repository is to become internal. On a non-public repository, code scanning needs a GitHub Code Security licence, so the codeql job would fail to upload its results after the switch. Ox Security and SonarCloud already scan this repository. CodeQL found four issues here so far, all actions/missing-workflow-permissions, all fixed, none open.

Changes

  • ci-cd.yml: the codeql job is gone.
  • _codeql.yml: deleted. No other workflow calls it.
  • actions.lock: regenerated with gh actions-lock --no-interactive --migrate-local-actions --no-narrow, which pruned the deleted workflow and github/codeql-action.

Ruleset

The repository ruleset "protected main" no longer has the code_scanning rule that required CodeQL results on main. With that rule in place, this PR and every later one would have waited for CodeQL results that never arrive.

Verified

With the versions and options of the org's "Lint workflow files" check:

  • actionlint 1.7.12 with the org's two ignore patterns: no findings.
  • zizmor --persona pedantic --no-online-audits: the same two informational use-trusted-publishing findings as on main.
  • gh-actions-lock v0.4.1: --verify and --verify-local pass.
  • npm run format:check passes.

🤖 Generated with Claude Code

The repository is to become internal, where code scanning needs a
GitHub Code Security licence. Ox Security and SonarCloud already scan
this repository, so the CodeQL job and its reusable workflow go.

Refs: TSSDK-84

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 11:23
@ox-security

ox-security Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

OX Security Logo

OX Security reviewed this pull request — nothing to fix.

✔ No issues found

Branch ci/TSSDK-84-remove-codeql → main

View scan in OX Security →

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

A maintainer must confirm removal of the CodeQL code_scanning requirement from the external “protected main” ruleset, as this merge prerequisite cannot be verified from the checkout.

No open issues 🎉

What changed in this PR

Removes CodeQL from the monorepo’s CI pipeline ahead of the repository becoming internal, avoiding the additional GitHub Code Security licensing requirement. Ox Security and SonarCloud remain in place.

Changes:

  • Removes the CodeQL job from the main CI/CD workflow.
  • Deletes the reusable CodeQL analysis workflow.
  • Prunes the deleted workflow and CodeQL action from the action lockfile.

The PR description identifies a merge prerequisite: remove the CodeQL requirement from the “protected main” ruleset.

File Description
.github/​workflows/​ci-cd.yml Removes the CodeQL job and its permissions.
.github/​workflows/​actions.lock Removes lock entries for the deleted workflow and CodeQL action.
.github/​workflows/​_codeql.yml Deletes the reusable CodeQL analysis workflow.

Review effort: Balanced

# Conflicts:
#	.github/workflows/ci-cd.yml
Copilot AI balanced review requested due to automatic review settings November 19, 2026 12:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the removal of CodeQL from CI.

No open issues 🎉

Review effort: Balanced

@sonarqubecloud

Copy link
Copy Markdown

@tobi-ax
tobi-ax merged commit 4be01c4 into main Nov 19, 2026
9 of 10 checks passed
@tobi-ax
tobi-ax deleted the ci/TSSDK-84-remove-codeql branch November 19, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants