Repository navigation
fix(pages): make a line taller by the borders its characters' shapes draw above and below #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Preserve the new border metrics when paragraphs reflow
The added border height lives only in
held, but_paragraphreplaces its computed metrics through_Reflow.atforpage.unequal, and_Reflowneither storesheldnor forwards it to_line_metrics. The new height therefore disappears on this supported layout path. Reproduction using this PR'spages_character_border_line_height.hwpx: remove line caches and encode two identical 21260-unit columns either assameSz="1", sameGap="0", colCount="2", or assameSz="0", colCount="2"with twocolSz width="16384" gap="0"children. Both resolve to exactly the same actual column widths, butestimate_pagesreports 66 different paragraph positions: paragraph 13 is at 3928 with equal-column encoding and 3840 with explicit-column encoding. The 10pt/0.1mm bordered line falls from height/advance 1056/1688 to 1000/1600 during same-width reflow. Carry border/held metrics through_Reflow.atand its banded path (rebasing offsets), or fail closed for combinations that cannot preserve them, and add a public regression for equivalent column-width encodings.