Repository navigation
fix(table-patch): line spacing in cells holding tables and fresh numbers for copies of copies - #659
Merged
Merged
Conversation
…ers for copies of copies set_cell_line_spacing now changes a cell's own paragraphs when the cell holds a table and never reaches into a table held by another cell. Nested tables copied with a cell, insert_block_by_clone and clone_table number tables, objects and paragraphs as Hancom numbers a pasted table, so copying a copy repeats no id. split_cell_vertical leaves its new parts empty. The object model's column width edits refuse to leave a cell narrower than the table nested in it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both merged after the 6.11.0 tag (a405857), so they belong under [Unreleased]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the three gaps left after #639 (nested tables).
Fixes
set_cell_line_spacingin a cell holding a table: changes the cell's own paragraphs (including the one holding the table) and drops only their line caches. A table or text box in the cell keeps its bytes. Before, choosing rows also changed the inner table's cells at the same address. An inner table is addressed by its owntable_index.idunused in the document and azOrderabove the document's, as Hancom numbers a pasted table (observed through public COM: SelectAll/Copy/Paste/SaveAs, then comparing the saved HWPX). Paragraphs take ids unused in the document. Before, copying a row holding a table twice repeated the table id, andinsert_block_by_clonetwice repeated paragraph ids.insert_block_by_clonenumbers pictures, shapes, fields and memos as row clones do; a block holding a chart, linked text boxes or a header/footer defined in a cell refuses.clone_tablenumbers the table and its nested tables and objects as a pasted table; before they kept the original's numbers.split_cell_verticalleaves each new part one empty paragraph of the cell's format; before it copied the content, so pictures and shapes repeated their numbers.set_column_widths/equalize_column_widthsrefuse (TableStructureError) a width that leaves a cell narrower than the table nested in it, and leave the table as it was.[Unreleased].The 248 tables flagged unsafe before any edit
They come from 4 private documents only, whose originals already carry stale line caches (text positions past the text, or missing lines). The check is right; no code change.
Verification
set_cell_line_spacingon every row, old (6.11.0) vs new, on tables holding tables or extra paragraph lists (970 tables, 221 documents):🤖 Generated with Claude Code