Repository navigation
fix(pages): follow empty lines beside a cell object with text on both sides - #661
Merged
Merged
Conversation
… sides In a table cell, Hancom sets an empty line reaching an object wrapped square with room for text on both sides beside it, two empty pieces at one height, the cell as tall as with room on one side. The estimate now follows such cells instead of leaving them unsupported; text beside such an object is still not followed. Reading a cell's layout caches, a line's second piece at its first's height no longer counts as a line of its own, which made the cell taller by a line for each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
airmang
commented
Nov 4, 2026
airmang
left a comment
Owner
Author
There was a problem hiding this comment.
검토 head 96536b0 / base 5ca12c7. _cell_band/_clear_of의 양쪽 여유 표지 보존, 캐시 있는 두 조각의 같은 높이 처리, 기존 셀 줄 배치와 호출부를 검토했습니다. 정확한 head의 전체 CI 7,639 passed/18 skipped/1 xfailed 및 Ruff/mypy/Pyright 로그를 확인했고, 로컬 관련 53개를 head와 최신 main 통합 tree be55a4d21b7ea68f86ed4eb44ee261a0ce71856d에서 각각 통과했습니다. 추가 공개 API 변형으로 그림 옆 빈 문단에 글을 넣었을 때 캐시 없는 경우에는 both-sides 사유로 지원 불가, 저장된 유효 캐시가 있으면 그대로 배치됨도 확인했습니다. 이 변경에서 미해결 결함은 발견하지 못했습니다. 자기 PR이므로 COMMENT로 검토를 기록하며, 병합 직전에 head/base/CI/미해결 스레드를 다시 확인합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇을 고쳤나
표 칸 안에 양쪽으로 글 자리가 있는 어울림 그림이나 도형이 있으면,
estimate_pages는 그 문서를 통째로 지원 밖(text on both sides of … wrapped square in a cell)으로 두었습니다.text on both sides of an object wrapped square in a cell로 바뀝니다.시험
pages_cell_object_on_both_sides_beside_empty_lines(5쪽)를 더했습니다.🤖 Generated with Claude Code