Repository navigation
Conversation
openapi-generator never deletes files for removed models. These 41 specs construct classes that src/index.js no longer exports, and because the generated specs register root-level beforeEach hooks, the first failure aborts the whole suite (0 passing). The generator does not recreate test specs for models outside the spec, so the removal is durable. Co-authored-by: Cursor <cursoragent@cursor.com>
Each release regenerates package.json but leaves the lockfile untouched, so they drifted (e.g. superagent 3.7.0 locked vs ^5.3.0 declared) and npm ci refused to install. Regenerated with npm install --package-lock-only, which keeps every existing resolution that still satisfies package.json. Co-authored-by: Cursor <cursoragent@cursor.com>
Runs npm ci, lint, test, compile and a type-check of the smoke scripts against dist, then auth and get-secret-value smoke tests against the compiled SDK using AKEYLESS_ACCESS_ID/AKEYLESS_ACCESS_KEY secrets. Tooling lives outside package.json (pinned npx versions, standalone eslint.config.mjs) because package.json is regenerated on every release. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
kgal-akl
marked this pull request as ready for review
November 12, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds PR CI for the JS SDK (ASM-21703) so dependency upgrades (including Dependabot security PRs) are validated before merge.
.github/workflows/pr-validation.ymlruns on PRs tomaster(and manually):npm ci --ignore-scripts, ESLint onsrc/,npm test,npm run build, verifydistloads and exportsApiClient/V2Api/Auth/GetSecretValue,tsctype-check of the smoke scripts againstdistdist, runsscripts/smoke/auth.js(access id/key auth) andscripts/smoke/get-secret-value.jsWhy the extra commits
Both pre-existing problems blocked the requested
npm ciandteststeps onmaster:src/index.jsno longer exports. The generated specs register root-levelbeforeEachhooks, so one failure aborted the entire suite (0 passing). After removal: 11,819 passing. The generator does not recreate specs for models outside the spec.package.jsonbut leavespackage-lock.jsonalone, so they drifted (superagent locked at 3.7.0 vs^5.3.0declared, mocha 9.2.2 vs^8.0.1), andnpm cirefused to install. Re-synced withnpm install --package-lock-only, which keeps every existing resolution that still satisfiespackage.json(31 package entries change, lockfile v2 unchanged). Consumers resolve frompackage.json, so the published package is unaffected.Design notes
git add .. New files (.github/,scripts/,.nvmrc,eslint.config.mjs) are kept, butpackage.jsonis overwritten, so nothing is added to it. ESLint and TypeScript run vianpxat pinned versions (ESLINT_VERSION/TYPESCRIPT_VERSIONin the workflow).no-undef,no-dupe-keys,no-dupe-class-members,no-unreachable,no-import-assign,no-const-assign).no-redeclareis omitted because the upstreamApiClienttemplate reusesvar kin two loops.checkJs: falseplus// @ts-checkin the smoke scripts, so the ~1,300 generated modules aren't checked but broken imports or renameddistexports fail the build. Method typos onV2Apiinstances aren't caught (Babel's class output infers loosely).scripts/smoke/, nottest/.npm testis also run byakeyless-main-repo's sdktest without these credentials.pull_request_target. All actions are SHA-pinned to their latest releases.actionlintandzizmorreport no findings.Required repo setup (before marking ready)
readon one dedicated smoke secret, e.g./ci/akeyless-javascript/smoke(a static secret with any non-empty value). No other permissions.AKEYLESS_ACCESS_ID,AKEYLESS_ACCESS_KEY,AKEYLESS_SMOKE_SECRET(the secret path from step 1)AKEYLESS_API_URL(defaults tohttps://api.akeyless.io)Verification
Ran every workflow step locally in
node:22:npm ci --ignore-scripts, lint,npm test(11,819 passing), build (1,333 files), dist export check,tsc(5.9.3 and 7.0.2): all passtscflags a misspelleddistexportauth.jsagainstapi.akeyless.iowith a real access key:auth: ok. With a bad key: HTTP 401 server message, key not present in outputget-secret-value.jsagainstapi.akeyless.io: request and token path work (unauthorized for an unreadable path, exits 1). Against a local stub API: success, empty value, and bad token are all handled correctlyOnce the secrets are configured, re-run this PR's checks and rebase one Dependabot PR (e.g. #25) to confirm smoke tests get the Dependabot secrets.
Follow-ups (not in this PR)
package.json, the next release regeneratespackage.jsonand reverts it, which can desync the lockfile again. Fix inakeyless-main-repogo/src/client/generate/main.go, similar toaddPackagesToResolutionsAndOverrides.src/modelfiles (and docs) for removed models are still compiled intodist, though not exported. The generator should prune files that are absent from.openapi-generator/FILESand the spec. New orphaned specs will reappear whenever a model is removed.masterviagit_push.sh. If these checks become required, the release token needs bypass..github/dependabot.ymlfor npm and github-actions, which also covers the pinned actions here.Summary by CodeRabbit
Tests
Chores