Conversation
The current description ("Security engine.") doesn't say what pac4j does.
The new one lists the supported protocols and states what sets it apart from
Spring Security in the same section: it is framework-agnostic, with adapters
for many Java web frameworks.
Disclosure: I'm the pac4j maintainer.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current description ("Security engine.") doesn't say what pac4j does. The new one lists the supported protocols and states what sets it apart from Spring Security in the same section: it is framework-agnostic, with adapters for many Java web frameworks.
Disclosure: I'm the pac4j maintainer.
Summary by cubic
Updates the
pac4jREADME entry to describe what the library actually does. The vague "Security engine" blurb is replaced with a summary of the supported protocols (OpenID Connect, SAML, CAS, OAuth, JWT, LDAP) and the Java framework adapters it ships with.Written for commit 20d9c2d. Summary will update on new commits.