Repository navigation
Index build job metadata lookups - #92
Merged
alexanderoster merged 1 commit intoOct 26, 2026
Merged
Conversation
Every Has/Get/StoreMetaDataString on buildjobmetadata and buildjobexecutionmetadata filters on (owner uuid, metadatakey, active), but neither table has an index, so each lookup scans the whole table. The tables grow with every job and execution, so opening a job's details gets slower as the build history grows: in a synthetic database with 460k metadata rows, reading 46 keys took 2.4 s, and 0.7 ms with the indices. The indices are created by a new CDatabaseMigrationClass::ensureIndices hook that runs after the schema migration on every start (CREATE INDEX IF NOT EXISTS). Existing databases get them on their next start without a schema version step, and no table or data changes. Unit tests check the query plans on a new database and on a database created without the indices.
Owner
|
Great find, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Has/Get/StoreMetaDataString on buildjobmetadata and buildjobexecutionmetadata filters on (owner uuid, metadatakey, active), but neither table has an index, so each lookup scans the whole table. The tables grow with every job and execution, so opening a job's details gets slower as the build history grows: in a synthetic database with 460k metadata rows, reading 46 keys took 2.4 s, and 0.7 ms with the indices.
The indices are created by a new CDatabaseMigrationClass::ensureIndices hook that runs after the schema migration on every start (CREATE INDEX IF NOT EXISTS). Existing databases get them on their next start without a schema version step, and no table or data changes.
Unit tests check the query plans on a new database and on a database created without the indices.