Skip to content

(Svelte) Let the list modules fill their grid cell #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderoster merged 1 commit into from
Oct 26, 2026
Merged

(Svelte) Let the list modules fill their grid cell #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Client/svelte/src/lib/amcf/modules/ModuleAlertList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@
</script>

{#if visible}
<div class="w-full border rounded-md overflow-hidden">
<ScrollArea class="max-h-[500px]">
<!-- Fills the space its container gives it (a grid cell) and scrolls inside; in a
stacked page it takes its natural height, at most one screen. -->
<div class="w-full flex-1 min-h-0 max-h-screen flex flex-col border rounded-md overflow-hidden">
<ScrollArea class="flex-1 min-h-0">
<Table.Root>
<Table.Header class="sticky top-0 bg-muted z-10">
<Table.Row>
Expand Down
6 changes: 4 additions & 2 deletions Client/svelte/src/lib/amcf/modules/ModuleBuildList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@
</script>

{#if visible}
<div class="w-full border rounded-md overflow-hidden flex-1 min-h-0 flex flex-col">
<ScrollArea class="h-full min-h-0 max-h-[60vh]">
<!-- Fills the space its container gives it (a grid cell) and scrolls inside; in a
stacked page it takes its natural height, at most one screen. -->
<div class="w-full flex-1 min-h-0 max-h-screen flex flex-col border rounded-md overflow-hidden">
<ScrollArea class="flex-1 min-h-0">
<Table.Root>
<Table.Header class="sticky top-0 bg-muted z-10">
<Table.Row>
Expand Down
6 changes: 4 additions & 2 deletions Client/svelte/src/lib/amcf/modules/ModuleConfigurationList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@
</script>

{#if visible}
<div class="w-full flex-1 min-h-0 border rounded-md overflow-hidden">
<ScrollArea class="h-full max-h-[400px]">
<!-- Fills the space its container gives it (a grid cell) and scrolls inside; in a
stacked page it takes its natural height, at most one screen. -->
<div class="w-full flex-1 min-h-0 max-h-screen flex flex-col border rounded-md overflow-hidden">
<ScrollArea class="flex-1 min-h-0">
<Table.Root>
<Table.Header class="sticky top-0 bg-muted z-10">
<Table.Row>
Expand Down
6 changes: 4 additions & 2 deletions Client/svelte/src/lib/amcf/modules/ModuleExecutionList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@
</script>

{#if visible}
<div class="w-full border rounded-md overflow-hidden">
<ScrollArea class="*:data-[slot=scroll-area-viewport]:max-h-[500px]">
<!-- Fills the space its container gives it (a grid cell) and scrolls inside; in a
stacked page it takes its natural height, at most one screen. -->
<div class="w-full flex-1 min-h-0 max-h-screen flex flex-col border rounded-md overflow-hidden">
<ScrollArea class="flex-1 min-h-0">
<Table.Root>
<Table.Header class="sticky top-0 bg-muted z-10">
<Table.Row>
Expand Down
12 changes: 7 additions & 5 deletions Client/svelte/src/lib/amcf/modules/ModulePartList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
</script>

{#if visible}
<div class="flex flex-col gap-3 w-full min-h-0">
<div class="flex flex-col gap-3 w-full flex-1 min-h-0">
{#if loading && !details}
<p class="text-sm text-muted-foreground">{loadingtext}</p>
{:else if errorMessage}
Expand All @@ -80,7 +80,7 @@
{:else}
{#if showdetails}
<!-- Build detail header -->
<div class="flex gap-3">
<div class="flex gap-3 shrink-0">
{#if thumbnailURL(details.thumbnail)}
<img
src={thumbnailURL(details.thumbnail)}
Expand All @@ -106,11 +106,13 @@
{/if}

<!-- Part list -->
<div class="text-xs font-semibold uppercase tracking-wider text-muted-foreground">
<div class="shrink-0 text-xs font-semibold uppercase tracking-wider text-muted-foreground">
Parts ({parts.length})
</div>
<div class="w-full border rounded-md overflow-hidden">
<ScrollArea class="max-h-[360px]">
<!-- The part table takes the space left below the build details and scrolls inside;
in a stacked page it takes its natural height, at most one screen. -->
<div class="w-full flex-1 min-h-0 max-h-screen flex flex-col border rounded-md overflow-hidden">
<ScrollArea class="flex-1 min-h-0">
<Table.Root>
<Table.Header class="sticky top-0 bg-muted z-10">
<Table.Row>
Expand Down
Loading