Skip to content

fix(engineering): keep draft PRs out of review attention - #18

Merged
christso merged 1 commit into
mainfrom
fix/github-attention-draft-policy
Nov 18, 2026
Merged

christso merged 1 commit into
mainfrom
fix/github-attention-draft-policy

Conversation

@christso

Copy link
Copy Markdown
Contributor

Summary

Draft PRs no longer enter GitHub attention's review or authored-PR action queues, even when a review is requested, a previous review was dismissed, or new commits arrive. A personal @handle mention can still surface as an informational candidate for a possible response; reviewing that draft requires an explicit user request. Team review requests, team mentions and replies alone do not qualify.

Non-draft review/re-request rules, explicit repository selection and read-only GitHub collection stay unchanged. Mention discovery retains its notification-window and access limitations; this is not a complete historical mention index.

Verification

  • bun run validate — validated all five plugins, both native catalogues and local Markdown references.
  • bun test — 62 passed, 0 failed; 339 assertions. Draft regressions cover direct/team requests, re-requests, dismissed reviews, changed heads, personal mention locations, notification-only signals and partial collection.
  • Rendered a deterministic main fixture report: a draft review request stays hidden, a personally mentioned draft appears as response-only information, and a ready review request needs action.
  • Live read-only helper run against explicitly selected allagentsdev/agent-plugins --days 1 — exit 0, two open PRs, no notification threads, no coverage warnings. Draft combinations were exercised by fixtures, not claimed from this live sample.
  • Focused correctness review and an independent adversarial review — no findings.

Post-Deploy Monitoring & Validation

No additional operational monitoring required: this is an on-demand, read-only helper with no service or GitHub mutation changes. After updating the installed skill, its next selected-repository report should keep drafts out of review work and label personal draft mentions as response-only candidates.

- Exclude drafts from review and authored-PR action queues.
- Surface personal draft mentions only as possible responses, never implicit review permission.
- Preserve non-draft review decisions and selected-repository/read-only boundaries.
- Cover draft requests, review history, mention locations, and partial collection with deterministic regressions.
@christso
christso merged commit 92fec22 into main Nov 18, 2026
1 check passed
@christso
christso deleted the fix/github-attention-draft-policy branch November 18, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant