Repository navigation
Fix Rectangle.is_orthant for one-sided and degenerate bounds - #425
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424.
Normalize absent bounds to negative/positive infinity, then check each coordinate interval as a pair. This supports one-sided orthants and rejects zero-width intervals or unrestricted coordinates. Add five cases to the existing constraints unittest class.
Validation: original actual class raised TypeError on both one-sided cases and returned True for [0,0]. Six synthetic class cases pass after the fix. The original orthant unittest plus the added method (five subcases) pass against the actual revised class, extracted with AST to avoid unrelated CasADi imports. Full Python/CasADi and Rust suites were not run; no solver or hardware workloads ran. Both files parse successfully.
Submitted under the existing dual MIT/Apache terms. Git author and committer explicitly use the authorized identity.