Skip to content

fix(shell): 🐛 harden helpers and add security reporting - #4

Merged
alsd4git merged 3 commits into
mainfrom
docs/security-policy
Oct 31, 2026
Merged

alsd4git merged 3 commits into
mainfrom
docs/security-policy

Conversation

@alsd4git

@alsd4git alsd4git commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Why

  • Publish the previously local Docker/netuse hardening together with the approved security baseline.
  • Address the first Codex review finding about exit/exec bypassing the netuse completion marker.

How

  • Preserve Docker registry configuration handling, credential-helper warnings and nonzero command statuses from the local commit.
  • Run the wrapped netuse command in an additional subshell so exit and exec cannot terminate the completion-marker writer.
  • Add exit 0, exit 7 and exec/exit 29 regression cases; document private vulnerability reporting in SECURITY.md.

Tests

  • ShellCheck and shfmt passed for the changed shell files.
  • ./tests/test-installer-functions.sh passed.
  • ./tests/docker-ubuntu-smoke.sh passed, including bounded Linux netuse tests on Bash and Zsh and Bash 3.2 compatibility.
  • git diff --check passed. No real installer, account credentials or macOS defaults were changed.

Respect DOCKER_CONFIG and warn about host credential helpers unavailable to Watchtower.

Preserve command exit codes through netuse and handle output without a trailing newline. Add Bash/Zsh regression tests and CI coverage.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T11:12:45.375961Z 3c659b5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c659b5066

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread general/.functions Resolved
@alsd4git alsd4git changed the title docs(security): 📝 document private vulnerability reporting fix(shell): 🐛 harden helpers and add security reporting Oct 31, 2026
@alsd4git
alsd4git merged commit 6f22fe3 into main Oct 31, 2026
13 checks passed
@alsd4git
alsd4git deleted the docs/security-policy branch October 31, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant