Skip to content

Vendor info enhancement - #321

Open
jaspals3123 wants to merge 11 commits into
developmentfrom
jaspal_vendor_info_enhancements
Open

jaspals3123 wants to merge 11 commits into
developmentfrom
jaspal_vendor_info_enhancements

Conversation

@jaspals3123

@jaspals3123 jaspals3123 commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator
{
  "name": "vendor info checks",
  "plugins": {
    "AmdSmiPlugin": {
      "collection_args": {},
      "analysis_args": {
        "min_hbm_gib_per_gpu": 288,
        "ecc_required": true
      }
    },
    "BiosPlugin": {
      "collection_args": {},
      "analysis_args": {
        "exp_server_vendor": "Supermicro",
        "exp_server_model": "AS -1234GS-ABC-LCC"
      }
    },
    "DeviceEnumerationPlugin": {
      "collection_args": {},
      "analysis_args": {
        "cpu_architecture": "x86_64",
        "min_cpu_cores": 128
      }
    },
    "MemoryPlugin": {
      "collection_args": {},
      "analysis_args": {
        "minimum_system_memory_gib": 3072,
        "memory_threshold": "4Ti",
        "ratio": 0.99
      }
    }
  }
}

jaspals3123 and others added 7 commits October 30, 2026 15:30
Quote the Windows CPU command so it survives OpenSSH and PowerShell, treat missing UMC RAS data as unavailable rather than an ECC mismatch, and finish the other memory checks after an installed-memory failure without letting a later pass set OK.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Comment on lines +62 to +70
CMD_CPU_INFO_WINDOWS = (
"powershell -NoProfile -Command "
"'$p = @(Get-CimInstance -ClassName Win32_Processor); "
"$cores = ($p | Measure-Object -Property NumberOfCores -Sum).Sum; "
"$map = @{0=''i686''; 5=''arm''; 6=''ia64''; 9=''x86_64''; 12=''aarch64''}; "
"$arch = $map[[int]$p[0].Architecture]; "
"Write-Output (''Architecture='' + $arch); "
"Write-Output (''Cores='' + $cores)'"
)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still wont work, it has to be like this:

Suggested change
CMD_CPU_INFO_WINDOWS = (
"powershell -NoProfile -Command "
"'$p = @(Get-CimInstance -ClassName Win32_Processor); "
"$cores = ($p | Measure-Object -Property NumberOfCores -Sum).Sum; "
"$map = @{0=''i686''; 5=''arm''; 6=''ia64''; 9=''x86_64''; 12=''aarch64''}; "
"$arch = $map[[int]$p[0].Architecture]; "
"Write-Output (''Architecture='' + $arch); "
"Write-Output (''Cores='' + $cores)'"
)
CMD_CPU_INFO_WINDOWS = (
'powershell -NoProfile -Command "'
"$p = @(Get-CimInstance -ClassName Win32_Processor); "
"$cores = ($p | Measure-Object -Property NumberOfCores -Sum).Sum; "
"$map = @{0='i686'; 5='arm'; 6='ia64'; 9='x86_64'; 12='aarch64'}; "
"$arch = $map[[int]$p[0].Architecture]; "
"Write-Output ('Architecture=' + $arch); "
"Write-Output ('Cores=' + $cores)\""
)

here is an example of it failing:

PS C:\WINDOWS\system32> powershell -NoProfile -Command "$p = @(Get-CimInstance -ClassName Win32_Processor); $cores = ($p | Measure-Object -Property NumberOfCores -Sum).Sum; $map = @{0='i686'; 5='arm'; 6='ia64'; 9='x86_64'; 12='aarch64'}; $arch = $map[[int]$p[0].Architecture]; Write-Output ('Architecture=' + $arch); Write-Output ('Cores=' + $cores)"
At line:1 char:56
+  = @(Get-CimInstance -ClassName Win32_Processor);  = ( | Measure-Obje ...
+                                                        ~
An empty pipe element is not allowed.
At line:1 char:228
+ ... ;  = [[int][0].Architecture]; Write-Output ('Architecture=' + ); Writ ...
+                                                                  ~
You must provide a value expression following the '+' operator.
At line:1 char:256
+ ... cture]; Write-Output ('Architecture=' + ); Write-Output ('Cores=' + )
+                                                                        ~
You must provide a value expression following the '+' operator.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : EmptyPipeElement

PS C:\WINDOWS\system32>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants