Repository navigation
DCERR-782: add generic OOB REST connection manager - #332
Merged
alexandraBara merged 5 commits intoNov 5, 2026
Merged
Conversation
alexandraBara
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a generic out-of-band REST connection manager under nodescraper/connection/oob_rest/, alongside the existing redfish/ and oob_ssh/ ones.
It's for controllers that log in with a username/password POST and then serve JSON over HTTPS. The login path and any extra login fields are configurable, so different controllers can be supported without writing a new subclass each time.
It follows the same three-part pattern as the other connection managers. OobRestConnectionParams holds the connection params (host, username, password, port, verify_ssl, timeout, login_path, login_payload_extra). OobRestConnection is the REST transport (authenticate, get, post, close). OobRestConnectionManager connects, authenticates to verify, and disconnects.
Any OOB plugin can reuse this instead of carrying its own REST client.
Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist