Skip to content

Fix first-run configuration file creation - #161

Merged
andreax79 merged 1 commit into
andreax79:mainfrom
dajiaohuang:fix-config-parent-directory
Oct 25, 2026
Merged

andreax79 merged 1 commit into
andreax79:mainfrom
dajiaohuang:fix-config-parent-directory

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

First-run configuration creation passes CONFIG_DIR / "config.ini" to read_config_file. When the Fernet key is missing, the function creates that file path as a directory and then fails when opening it for writing. Create the parent directory instead.

Adds a regression using an isolated temporary directory and a fresh ConfigParser; it checks that the resulting file contains the generated Fernet key.

Validation: the new pytest regression fails on the original implementation (PermissionError on Windows because config.ini is a directory) and passes with this fix. An isolated Python 3.13 pytest run gave 22 passed, 18 failed and 2 errors; failures include Windows path assumptions, read-only Git fixture cleanup, and unavailable Airflow imports. The documented Docker/Airflow make test environment was not run, so full integration validation remains incomplete. No Airflow service or DAG execution was used.

@andreax79
andreax79 merged commit d328e98 into andreax79:main Oct 25, 2026
3 checks passed
@andreax79

Copy link
Copy Markdown
Owner

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants