Repository navigation
Fix first-run configuration file creation - #161
Merged
andreax79 merged 1 commit intoOct 25, 2026
Merged
Conversation
Owner
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-run configuration creation passes
CONFIG_DIR / "config.ini"toread_config_file. When the Fernet key is missing, the function creates that file path as a directory and then fails when opening it for writing. Create the parent directory instead.Adds a regression using an isolated temporary directory and a fresh ConfigParser; it checks that the resulting file contains the generated Fernet key.
Validation: the new pytest regression fails on the original implementation (PermissionError on Windows because config.ini is a directory) and passes with this fix. An isolated Python 3.13 pytest run gave 22 passed, 18 failed and 2 errors; failures include Windows path assumptions, read-only Git fixture cleanup, and unavailable Airflow imports. The documented Docker/Airflow
make testenvironment was not run, so full integration validation remains incomplete. No Airflow service or DAG execution was used.