Repository navigation
Avoid reloading and remeshing strokes on every Room note update. - #130
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1022860218
branch
2 times, most recently
from
November 20, 2026 15:11
acc989f to
ce058c2
Compare
Because strokes are stored on the `notes` row, saving finished strokes re-triggered `getNoteStream(noteId)` in both `DrawingCanvasViewModel` and any backstack `HomeScreenViewModel`, causing both ViewModels to re-decode JSON and regenerate native `Stroke` meshes on the main thread after every stroke. Load initial strokes only once in `DrawingCanvasViewModel` so subsequent `Note` emissions update metadata without re-decoding or replacing in-memory `Stroke` instances, and defer stroke reloads in `HomeScreenViewModel` while `uiState` has no active UI subscribers. Selecting a different note on the Home screen now clears the previous note's strokes immediately, so the preview is briefly empty while the new note loads. PiperOrigin-RevId: 1026458631
copybara-service
Bot
force-pushed
the
test_1022860218
branch
from
November 20, 2026 15:19
ce058c2 to
b5b23c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid reloading and remeshing strokes on every Room note update.
Because strokes are stored on the
notesrow, saving finished strokes re-triggeredgetNoteStream(noteId)in bothDrawingCanvasViewModeland any backstackHomeScreenViewModel, causing both ViewModels to re-decode JSON and regenerate nativeStrokemeshes on the main thread after every stroke.Load initial strokes only once in
DrawingCanvasViewModelso subsequentNoteemissions update metadata without re-decoding or replacing in-memoryStrokeinstances, and defer stroke reloads inHomeScreenViewModelwhileuiStatehas no active UI subscribers.Selecting a different note on the Home screen now clears the previous note's strokes immediately, so the preview is briefly empty while the new note loads.