Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
prmukherj
commented
Nov 21, 2026
| @@ -37,6 +37,6 @@ To assign the expression to a named expression in a live Fluent solver: | |||
| >>> # Assign to a named expression and evaluate | |||
| >>> # The expression is converted to string format: "AreaAve(AbsolutePressure,['inlet1'])" | |||
| >>> named = solver_session.settings.setup.named_expressions.create() | |||
Collaborator
Author
There was a problem hiding this comment.
This will still work without any deprecation warning:
solver_session.settings.setup.named_expressions = {}
prmukherj
commented
Nov 21, 2026
| >>> # The expression is converted to string format: "AreaAve(AbsolutePressure,['inlet1'])" | ||
| >>> named = solver_session.settings.setup.named_expressions.create() | ||
| >>> named.definition = expr | ||
| >>> named.definition.set_state(expr) |
Collaborator
Author
There was a problem hiding this comment.
However after creation if we do this then we will get deprecation warning now.
prmukherj
marked this pull request as ready for review
November 21, 2026 07:23
Collaborator
Author
|
Apologies for the number of files changed in this PR but the actual changes are limited to only a few files, and the other files just contain the refactored syntaxes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Direct assignment of values to the parameters could make us land into issues like:
works but
just ends up setting z to the object.
Change Summary
The
=based direct assignment has been deprecated for all such settings and object model items and only setting state viaset_stateis recommended.Rationale
To prevent issues and confusions like the ones mentioned in the issue and above.
Impact
Users to get a clear message and be advised to use the
set_statefor setting values.