Repository navigation
Conversation
Author
|
Thanks for flagging, @chauvuusvn. Closing in favor of #1976, which was opened earlier for #1975 and already includes a regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guards
_chunk_bytes_to_sseinanthropic.lib.bedrock._stream_decoderagainstNoneor non-bytespayloads.When AWS Bedrock sends an empty chunk frame, a control payload, or a chunk dictionary where
chunk.get("bytes")isNone(e.g.chunk = {"bytes": None}orchunk = {}),_chunk_bytes_to_ssepreviously calledraw.decode()unconditionally, resulting inAttributeError: 'NoneType' object has no attribute 'decode'.With this change,
_chunk_bytes_to_ssesafely returnsNoneto drop non-bytes or empty payloads without crashing the active stream.Closes #1975