Repository navigation
fix: Verify release candidates under the physical temporary path - #505
Merged
CurtHagenlocher merged 1 commit intoNov 16, 2026
Merged
Conversation
On macOS the temporary directory is under /var, which is a symlink to /private/var. verify_rc.sh worked under the symlinked path, so tools could see the same files under both paths. On the newer macOS runner image, MSBuild then treated each project as two and built them concurrently into the same outputs, failing with spurious "type or namespace not found" errors. Resolving VERIFY_TMPDIR to its physical path makes every tool see one path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
On macOS,
verify_rc.shcan fail with dozens of spurious compile errors in the test step: "type or namespace name 'FlightTicket' could not be found",K4osnot found in the compression tests, and so on, even though the same projects built successfully moments earlier in the build step.The cause is the temporary directory. On macOS it's under
/var, which is a symlink to/private/var, and the script works under the symlinked path. Tools can then see the same files under both/var/folders/…and/private/var/folders/…. When that happens, MSBuild treats each project as two different projects and builds them concurrently into the same output folder, so builds read references that another build is still writing.Evidence
From the
Verify (8.0.x, macos-latest)job of the RC workflow on #504:/var/private/var20261103.62920261028.624main20261028.624Every run reports its sandbox under
/var/folders/…, but only the run on the newer image ended up with both paths in use. So this is likely to start failing onmaintoo once that image becomes the default formacos-latest.The fix
setup_tmpdirnow resolvesVERIFY_TMPDIRto its physical path withpwd -Pbefore anything works in it, so the shell's$PWDand the operating system's view of the current directory agree. This applies both when the script creates the directory withmktempand when the caller suppliesVERIFY_TMPDIR. The cleanup trap removes the same directory either way. On Linux and Windows, where the path normally has no symlinks, nothing changes.Testing
setup_tmpdir(mktempand a caller-suppliedVERIFY_TMPDIR) resolve to the physical path,$PWDis physical after thecd, and the cleanup trap still removes the directory.shellcheck0.10.0 (the version pinned in.pre-commit-config.yaml) andshfmtreport no issues.macos-latest.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com