Repository navigation
chore: Migrate from the pull_request_target trigger - #128
Benjamin-Philip wants to merge 8 commits into
Conversation
|
Preview URL: https://Benjamin-Philip.github.io/arrow-erlang-1 If the preview URL doesn't work, you may have forgotten to configure your fork repository for preview. |
It's a test that opens a PR from the same repository not a fork repository. This change will not work with a PR from a fork repository... |
The changes I've made are based on the example in the GitHub Actions docs and a similar workflow in the Erlang/OTP repo. The repository difference becomes an issue if I used the If you still want to test, I could make a PR against your fork. |
|
I've pushed this branch to my fork's main with an adaption kou@301c843 : https://github.com/kou/arrow-erlang/ |
|
I've created a PR here: kou#1. Looks like you'll need to approve running the workflows first. |
What issue does this PR close?
Closes #126.
What's Changed
This PR migrates the PR Comment workflow from the
pull_request_targettrigger to theworkflow_runtrigger. Commenting the Preview URL is now a 2 step process. First, the preview comment is generated and uploaded in the Docs workflow in the context of the fork repo. Then, the completed Docs workflow triggers the PR Comment workflow, which downloads and makes the preview comment in the context of the base repo.Tested in this dummy PR via manual
workflow_dispatch: Benjamin-Philip#1