Skip to content

Add incubating as a tag to wheel - #1037

Draft
jernejfrank wants to merge 1 commit into
mainfrom
fix/43_release_leftover
Draft

jernejfrank wants to merge 1 commit into
mainfrom
fix/43_release_leftover

Conversation

@jernejfrank

Copy link
Copy Markdown
Contributor

Long overdo, addressing #901 items that got flagged during the last release.

The individual items are split in single contained commits, but happy to split things up further if necessary.

Changes

  • Add 1incubating as a wheel tag to have it in the python wheel

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@enekoreto enekoreto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out locally, building the wheel with _build_wheel_from_current_dir (UI build skipped), flit 4.2.0 and wheel 0.48.0. The tagged wheel looks good: two clean builds are identical and compare-wheels passes on them, twine check passes, it installs as apache-burr 0.43.0, and its WHEEL file has Build: 1incubating. The release script tests and CI's test command pass.

One problem shows up when building twice in the same checkout, for example a new RC of the same version, since the script doesn't clean dist/: the glob dist/apache_burr-{version}*.whl also matches the tagged wheel from the previous run. On macOS that one comes first, so the old wheel is the one that gets retagged and returned, and the new build stays in dist/ untagged. I changed a file between two runs: on main the second run returns a wheel with the change, here it returns the old one, and dist/ ends up with two wheels, which _collect_all_artifacts would both pick up. Globbing flit's exact output name, dist/apache_burr-{version}-py3-none-any.whl, fixed it in my test, since wheel tags then replaces the old tagged file.

Release Validation is red, but only in the summary step: only the 3.12 install-and-smoke job ran, and the others and sdist-wheel-equivalence show as abandoned, so it probably just needs a re-run.

Small thing: the from-scratch build steps in scripts/README.md and the usage line in scripts/ci_smoke_server.py still use the untagged name.

I ran this on Python 3.13 on macOS.

@jernejfrank

Copy link
Copy Markdown
Contributor Author

I tried this out locally, building the wheel with _build_wheel_from_current_dir (UI build skipped), flit 4.2.0 and wheel 0.48.0. The tagged wheel looks good: two clean builds are identical and compare-wheels passes on them, twine check passes, it installs as apache-burr 0.43.0, and its WHEEL file has Build: 1incubating. The release script tests and CI's test command pass.

Hi, thanks for taking a look. THere has been some development on the dev mailing list: https://lists.apache.org/thread/7t31297fhwqp9sqo6nvopgf0qw10zy4y, so will probably need to change some things around. Will try to find some time in the next couple of days.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants