Reject AppCookie LB stickiness policy on Virtual Router networks

[sureshanaparti]

Description

This PR rejects AppCookie (App session) based stickiness type policy for Virtual Router.

Fixes #3253

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Create VPC, network tier(s) and deploy instance on it.
• Acquire public IP and configure load balancing rule.
• On load balancing rule, configure sticky policy with 'AppCookie' method (this should fail with error).

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.40%. Comparing base (5deb6a9) to head (e91b9e5).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #13315      +/-   ##
============================================
+ Coverage     16.38%   16.40%   +0.01%     
- Complexity    13627    13637      +10     
============================================
  Files          5669     5669              
  Lines        501541   501529      -12     
  Branches      60925    60920       -5     
============================================
+ Hits          82190    82264      +74     
+ Misses       410142   410047      -95     
- Partials       9209     9218       +9     

Flag	Coverage Δ
uitests	4.16% <ø> (ø)
unittests	17.26% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

I think, a simple solution might be

cloudstack/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java

Line 997 in 7308dad

} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {

throwing an exception after this line

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18115

[sureshanaparti]

I think, a simple solution might be

cloudstack/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java

Line 997 in 7308dad

} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {

throwing an exception after this line

let me check it @weizhouapache

[weizhouapache]

@sureshanaparti
is this still WIP ?

[DaanHoogland]

ping @sureshanaparti

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19367