Allocated volume pool allocation improvements - #14275
Open
sureshanaparti wants to merge 1 commit into
Open
sureshanaparti wants to merge 1 commit into
sureshanaparti wants to merge 1 commit into
Conversation
- Allow recreate volume for Allocated volumess with pool id - Change pool allocation logic to prioritise exising pool - Fix VM deployment logic for allocated volume reuse
Contributor
Author
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14275 +/- ##
=========================================
Coverage 18.00% 18.01%
- Complexity 16219 16233 +14
=========================================
Files 5936 5936
Lines 535716 535729 +13
Branches 65596 65598 +2
=========================================
+ Hits 96459 96509 +50
+ Misses 428268 428225 -43
- Partials 10989 10995 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19356 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Allocated volumes with a pool id to go through the pool allocation logic. It gives preference to the poolId already existing on the volume. If suitable, it will reuse the same pool, else will continue with the pool allocation logic.
The same thing has been implemented for the VM deployment logic - if the VM start operation fails with the root volume in Allocated state but assigned poolId, it will retry with the same poolId or go through pool allocation if needed.
Changes:
If a volume fails during encryption etc during the first attach flow, the pool id of the volume gets set but the volume state remains in Allocated state. The next re-attach fails as the current logic for pool allocator expects the poolId for the volume to be null.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?