Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The new SHA matches v4.6.0 and the ASF allowlist entry.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the Docker registry login action to an ASF-approved version, restoring the allowlist check.
Changes:
- Pins
docker/login-actionto the allowlisted v4.6.0 commit.
| File | Description |
|---|---|
.github/workflows/docker-cloudstack-simulator.yml |
Updates the Docker login action pin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #14276 +/- ##
=============================================
- Coverage 19.91% 3.71% -16.21%
=============================================
Files 6373 487 -5886
Lines 577230 41992 -535238
Branches 70696 7942 -62754
=============================================
- Hits 114950 1558 -113392
+ Misses 449713 40208 -409505
+ Partials 12567 226 -12341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
https://github.com/apache/infrastructure-actions/blob/d545588139850a104de28a3a203555f719e0393a/approved_patterns.yml#L164
docker/login-action@dbcb813
refs #14113
The ASF Allowlist failed on main:
https://github.com/apache/cloudstack/actions/runs/36711972556/job/109875691427
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?