NetworkGarbageCollector can tear down a network with a live Running VR - #14281
Draft
DaanHoogland wants to merge 1 commit into
Draft
DaanHoogland wants to merge 1 commit into
DaanHoogland wants to merge 1 commit into
Conversation
… Running VR countNicsForNonStoppedRunningVrs() in NicDaoImpl checked VR state Starting/Stopping/Migrating but omitted Running, so a router that resynced back to Running after a spurious PowerReportMissing was never counted, letting isNetworkReadyForGc() approve garbage collection of a network with a live NIC/VR. Added VirtualMachine.State.Running to the state filter and a test, NicDaoImplTest#testCountNicsForNonStoppedRunningVrsIncludesRunningState, which fails without the fix (asserts the join's state parameters include Running). Generated-by: Claude Code (claude-sonnet-5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14281 +/- ##
=========================================
Coverage 18.00% 18.00%
+ Complexity 16220 16219 -1
=========================================
Files 5936 5936
Lines 535716 535716
Branches 65596 65596
=========================================
+ Hits 96457 96462 +5
+ Misses 428269 428264 -5
Partials 10990 10990
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
countNicsForNonStoppedRunningVrs() in NicDaoImpl checked VR state Starting/Stopping/Migrating but omitted Running, so a router that resynced back to Running after a spurious PowerReportMissing was never counted, letting isNetworkReadyForGc() approve garbage collection of a network with a live NIC/VR.
Added VirtualMachine.State.Running to the state filter and a test, NicDaoImplTest#testCountNicsForNonStoppedRunningVrsIncludesRunningState, which fails without the fix (asserts the join's state parameters include Running).
Generated-by: Claude Code (claude-sonnet-5)
Description
This PR...
Fixes: #14177
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?