Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The filter change is correct and the legal-file edits only remove trailing whitespace.
Review effort: Balanced
Findings: None
What changed in this PR
Expands trailing-whitespace enforcement to nested license and notice files and cleans existing violations.
Changes:
- Broadens the pre-commit filename filter.
- Removes trailing whitespace from Whisker legal files.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Includes nested LICENSE, NOTICE, and README files. |
tools/whisker/LICENSE |
Removes trailing whitespace. |
tools/whisker/NOTICE |
Removes trailing whitespace. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #14288 +/- ##
=============================================
- Coverage 19.91% 3.71% -16.21%
=============================================
Files 6373 487 -5886
Lines 577230 41992 -535238
Branches 70696 7942 -62754
=============================================
- Hits 114950 1558 -113392
+ Misses 449713 40208 -409505
+ Partials 12567 226 -12341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
https://github.com/pre-commit/pre-commit-hooks#trailing-whitespace
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?