Skip to content

Auto remove trailing whitespace with pre-commit - #14288

Open
jbampton wants to merge 1 commit into
apache:mainfrom
jbampton:remove-trailing-whitespace
Open

jbampton wants to merge 1 commit into
apache:mainfrom
jbampton:remove-trailing-whitespace

Conversation

@jbampton

@jbampton jbampton commented Oct 1, 2026

Copy link
Copy Markdown
Member

https://github.com/pre-commit/pre-commit-hooks#trailing-whitespace

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI balanced review requested due to automatic review settings October 1, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The filter change is correct and the legal-file edits only remove trailing whitespace.

Review effort: Balanced
Findings: None

What changed in this PR

Expands trailing-whitespace enforcement to nested license and notice files and cleans existing violations.

Changes:

  • Broadens the pre-commit filename filter.
  • Removes trailing whitespace from Whisker legal files.
File Description
.pre-commit-config.yaml Includes nested LICENSE, NOTICE, and README files.
tools/​whisker/​LICENSE Removes trailing whitespace.
tools/​whisker/​NOTICE Removes trailing whitespace.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.71%. Comparing base (1a48a87) to head (b79f9ac).

❗ There is a different number of reports uploaded between BASE (1a48a87) and HEAD (b79f9ac). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1a48a87) HEAD (b79f9ac)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #14288       +/-   ##
=============================================
- Coverage     19.91%    3.71%   -16.21%     
=============================================
  Files          6373      487     -5886     
  Lines        577230    41992   -535238     
  Branches      70696     7942    -62754     
=============================================
- Hits         114950     1558   -113392     
+ Misses       449713    40208   -409505     
+ Partials      12567      226    -12341     
Flag Coverage Δ
uitests 3.71% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants