Repository navigation
feat: support native wide-decimal hashing - #6548
Merged
andygrove merged 12 commits intoOct 20, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5994.
Rationale for this change
Native wide-decimal hashing used different bytes from Spark, so mixed native/JVM shuffle could lose matching join rows. Make precision 19–38 hashing Spark-compatible and enable native SQL
hash/xxhash64.What changes are included in this PR?
How are these changes tested?
At
33682c0ee, upstream CI passed, including Rust, native build, lint, Spark 4.1 suites and TPC-H/TPC-DS. The merge includes #6740's Spark 4.2 timestamp fix; hashing code is unchanged from8b1d26a32. Supplemental Spark SQL and cross-profile CI: requested via fork #35, but fork Actions is blocked and no current-head run started. Please applyrun-spark-4.1-testsandrun-all-spark-profilesupstream before queueing.Historical fork CI covered Spark 4.1 SQL and mixed shuffle on Spark 4.1/4.2; its Spark 4.2 expression failure predates the main update and is not a current-head verdict.
Historical benchmarks at
27faa50edmeasured 5.0–14.2x Murmur3 and 2.1–15.8x xxhash64 improvements over the pre-optimization native decimal-array path. Whole-query native array hashing averaged 83–89 ms versus 159–176 ms with Spark hash fallback. These local measurements were not rerun for this merge. Benchmark source.