Conversation
notroj
force-pushed
the
md-refactoring
branch
2 times, most recently
from
September 22, 2026 18:11
e67d1e0 to
0237e68
Compare
* modules/md/md_util.h, modules/md/md_util.c (md_util_exec_cmdline): New function, tokenizing only the configured command line and passing the remaining arguments verbatim. * modules/md/md_acme_authz.c (md_acme_authz_update): Reject an authorization identifier which is not a DNS name or wildcard. (cha_dns_01_setup, cha_dns_01_teardown): Use md_util_exec_cmdline(). * modules/md/mod_md.c (notify): Use md_util_exec_cmdline() for MDNotifyCmd and MDMessageCmd. * modules/md/md_acme_order.c (md_acme_order_start_challenges): Log the authz url, authz is NULL if the retrieve failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
test/modules/md/test_721_dns01.py: New test suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* modules/md/md_util.c (md_util_base64url_encode, md_util_base64url_decode): Implement using apr_pencode_base64_binary() and apr_pdecode_base64_binary() if APR is 1.7.0 or later, keeping the local implementation for older APR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Use the curl binary the test framework is configured with. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* modules/md/md_crypt.c (chain_to_buffer): New function, rendering the chain into a memory BIO like cert_to_buffer() does for a single cert. (md_chain_fsave): Use it with md_util_freplace(), so an interrupted write no longer leaves a truncated pubcert.pem behind. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* modules/md/md_util.c (md_text_fcreatex): Return the status of the write and the close. The permissions were set a second time here, overwriting the status; md_util_fcreatex() already sets them. (md_util_freplace): Keep the status of the last file creation, so a failure to create the temporary file can no longer be reported as success and have the write use an uninitialized handle. Remove the temporary file when the write fails too, not only on rename failure. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
notroj
force-pushed
the
md-refactoring
branch
from
September 22, 2026 21:25
0237e68 to
1ee7c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.