Skip to content

ci: enforce standard-library includes with misc-include-cleaner #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuzhang wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

ci: enforce standard-library includes with misc-include-cleaner #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Checks: |
clang-analyzer-*,
google-*,
modernize-*,
misc-include-cleaner,
readability-identifier-naming,
readability-isolate-declaration,
-modernize-use-nodiscard,
Expand All @@ -41,5 +42,11 @@ CheckOptions:
value: '_'
- key: modernize-use-scoped-lock.WarnOnSingleLocks
value: 'false'
# misc-include-cleaner is scoped to standard-library headers only. Project
# headers (iceberg/) and third-party headers are ignored so the check does
# not demand a direct include for every symbol that an already-included
# project header provides (the noise that led to its removal in #708).
- key: misc-include-cleaner.IgnoreHeaders
value: 'iceberg/.*;arrow/.*;avro/.*;aws/.*;benchmark/.*;cpr/.*;curl/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;openssl/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;thrift/.*;libpq-fe\.h;mysql\.h;sqlite3\.h;utf8proc\.h;zlib\.h'

HeaderFilterRegex: 'src/iceberg|example'
Loading