Repository navigation
Conversation
Keep server-provided token_type values out of validation errors while preserving the error kind and allowed-type diagnostic. Cover malformed responses through both FetchToken and ExchangeToken.
zhjwpku
added a commit
to zhjwpku/iceberg-cpp
that referenced
this pull request
Nov 1, 2026
Restore the upstream token-response parser and keep the targeted validation-error fix and regression coverage in PR apache#1079.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth token response validation includes an unsupported
token_typevalue in the returned error, allowing response-provided data to reach application logs. Omit that value while preserving the validation error kind and the allowed-type diagnostic. JSON parse errors already omit response values.Add regression coverage through both client-credentials and token-exchange requests for malformed JSON, missing fields, wrong field types and invalid token types. The regression fails before the fix through both request paths.
Validation: REST suite (499 passed, 1 skipped), pre-commit, and clang-tidy on changed lines.