Repository navigation
Infra: Replace archived pydocstyle hook with ruff D rules - #4014
Open
rambleraptor wants to merge 1 commit into
Open
rambleraptor wants to merge 1 commit into
rambleraptor wants to merge 1 commit into
Conversation
pycqa/pydocstyle is archived, which zizmor 1.30.0 flags as archived-uses in .pre-commit-config.yaml. Enable ruff's pydocstyle rules with the same ignore list and fix the docstrings it reports. Co-authored-by: Fokko Driesprong <fokko@apache.org> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Fokko
approved these changes
Oct 1, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Nice! Thanks @rambleraptor
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2026
Collaborator
Author
|
@Fokko @kevinjqliu can one of you re-add this to the merge queue? The bot took it off for...reasons? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#3920 is showing that the new zizmor-action GitHub action doesn't like our pydocstyle check. We should consolidate this behind ruff, so we can avoid the extra dependency.
Are these changes tested?
GitHub actions should continue to pass.
Are there any user-facing changes?