Repository navigation
Test with maven-testing and drop the explicit Guice dependency - #730
Merged
Merged
Conversation
maven-testing brings the Guice and maven-xml that Maven core ships; the retired plugin-testing harness did not, which is why Guice was declared and maven-xml pinned here.
slachiewicz
marked this pull request as ready for review
October 24, 2026 11:18
gnodet-bot
approved these changes
Oct 24, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. Clean migration from maven-plugin-testing-harness:4.0.0-beta-4 to maven-testing:${mavenVersion} — the workarounds (Guice 7.0.0 dep and maven-xml pin) were artifacts of the old harness and are correctly removed. The ArtifactStub import moves to the canonical new package. Consistent with the companion install-plugin PR #478.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the retired
org.apache.maven.plugin-testing:maven-plugin-testing-harness4.0.0-beta-4 withorg.apache.maven:maven-testing:${mavenVersion}.maven-testingdepends on theguice:classesandmaven-xmlthat Maven core ships, so the explicit Guice test dependency (on 7.0.0, which drops the javax.inject support Maven 4 still uses) and themaven-xmlpin that worked around the old harness's rc-3maven-xmlare both removed.DeployFileMojoTestnow importsArtifactStubfromorg.apache.maven.testing.plugin.stubs: inmaven-testingtheorg.apache.maven.api.plugin.testing.stubsclass is a deprecated relocation shim with only a no-arg constructor. Same change as apache/maven-install-plugin#478.Verified:
mvn verifyon Maven 4.0.0-rc-7, JDK 17 → 50 tests, 0 failures.