Skip to content

NioDatagramAcceptorTest - static ExceptionMonitor filtering #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-thing merged 3 commits into from
Oct 13, 2026
Merged

NioDatagramAcceptorTest - static ExceptionMonitor filtering #78

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
690b5a2
filtering exceptions from NioDatagramAcceptor
the-thing Oct 5, 2026
5bb8e0f
Additional logging added
the-thing Oct 10, 2026
1ad92cf
Print test names for caught exceptions.
the-thing Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions mina-core/src/test/java/org/apache/mina/transport/socket/nio/NioDatagramAcceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@
import org.apache.mina.transport.socket.DatagramSessionConfig;
import org.apache.mina.util.AcceptorBindUtil;
import org.apache.mina.util.ExceptionMonitor;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestName;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
Expand All @@ -34,14 +38,24 @@

public class NioDatagramAcceptorTest {

private static final Logger LOGGER = LoggerFactory.getLogger(NioDatagramAcceptorTest.class);

@Rule
public TestName testName = new TestName();

@Test
public void shouldDisposeAcceptorSilentlyWhenExecutorIsShutdown() {
AtomicReference<Throwable> exception = new AtomicReference<>();

ExceptionMonitor previous = ExceptionMonitor.getInstance();
ExceptionMonitor.setInstance(new ExceptionMonitor() {
@Override
public void exceptionCaught(Throwable cause) {
exception.set(cause);
LOGGER.error("Exception caught in test {}", testName.getMethodName(), cause);

if (isFromNioDatagramAcceptor(cause)) {
exception.set(cause);
}
}
});

Expand All @@ -61,18 +75,23 @@ public void exceptionCaught(Throwable cause) {
assertNull("Exception must not be thrown when disposing executor service", exception.get());
}
} finally {
ExceptionMonitor.setInstance(null);
ExceptionMonitor.setInstance(previous);
}
}

@Test
public void shouldThrowExceptionWhenThreadIsInterruptedAndServiceIsNotDisposing() {
AtomicReference<Throwable> exception = new AtomicReference<>();

ExceptionMonitor previous = ExceptionMonitor.getInstance();
ExceptionMonitor.setInstance(new ExceptionMonitor() {
@Override
public void exceptionCaught(Throwable cause) {
exception.set(cause);
LOGGER.error("Exception caught in test {}", testName.getMethodName(), cause);

if (isFromNioDatagramAcceptor(cause)) {
exception.set(cause);
}
}
});

Expand Down Expand Up @@ -103,7 +122,17 @@ public void exceptionCaught(Throwable cause) {
}
}
} finally {
ExceptionMonitor.setInstance(null);
ExceptionMonitor.setInstance(previous);
}
}

private static boolean isFromNioDatagramAcceptor(Throwable cause) {
for (StackTraceElement stackTraceElement : cause.getStackTrace()) {
String className = stackTraceElement.getClassName();
if (className.equals(NioDatagramAcceptor.class.getName())) {
return true;
}
}
return false;
}
}
Loading