Skip to content

skip adding commas in extends list closes Issue9563 - #9637

Open
homberghp wants to merge 2 commits into
apache:masterfrom
homberghp:issue9563
Open

homberghp wants to merge 2 commits into
apache:masterfrom
homberghp:issue9563

Conversation

@homberghp

Copy link
Copy Markdown
Contributor

solves #9563

Added a test to ensure the non-generic extends clause keeps working

The change is in CasualDiff#diffList2

To improve readability, indented a small part in CasualDiff#diffClassDef

The bug caused the addition of superfluous commas in a list of generic types in a extends list of an interface.

I did not use any LLM or AI in this solution.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

LLMs, Commit messages and PR description:

  • Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
  • LLM assisted commits should be attributed with an Assisted-by: MODEL_NAME MODEL_VERSION line appended to the commit message.
    • Please mention coding assistance in the PR description too (eg. by adding the same Assisted-by line from above)
    • Please describe the changes in your own words - we'd like to know you understand the changes being made!

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

added test to ensure non generic extends clause keeps working

solves apache#9563
The change is in CasualDiff#diffList2

To improve redeability, indented small part in CasualDiff#diffClassDef
@homberghp homberghp changed the title Added test to show Issue9563 skip adding commas in extends list closes Issue9563 Sep 24, 2026
@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 25, 2026
@apache apache locked and limited conversation to collaborators Sep 25, 2026
@apache apache unlocked this conversation Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants