Skip to content

upgrade some commons libs, jsvg, junit and testng - #9641

Open
ebarboni wants to merge 7 commits into
apache:masterfrom
ebarboni:platformclusterlibupgrade
Open

ebarboni wants to merge 7 commits into
apache:masterfrom
ebarboni:platformclusterlibupgrade

Conversation

@ebarboni

Copy link
Copy Markdown
Contributor

upgrade libraries in platform cluster.

commons (io,lang3,logging,codec)

jsvg

upgrade the test framework update testNG 7.12.0 and junit (only to 5.14.4 not major but looks more easy thant 4 to 5 migration).

maven project generation use same version now
ant projet testng lib synchronized with 7.12.0

may help fixing: #9561 integrated the modification suggested by @matthiasblaesing

Used a new bundle to progress indicator as there is a bundle error, not sure the root cause java/testng/src/org/netbeans/modules/testng/ProgressIndicator.java

@ebarboni ebarboni added this to the NB32 milestone Sep 24, 2026
@ebarboni ebarboni added Upgrade Library Library (Dependency) Upgrade ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 24, 2026
@mbien

mbien commented Sep 24, 2026

Copy link
Copy Markdown
Member

IMO: multi lib updates (of mostly unrelated libraries) should be split into individual commits, one per updated lib wrapper. Each commit should also get a proper commit message. "upgrade platform lib" for so many libraries is not sufficient to tell the story what the commit actually includes.

This could be still fixed here since wrapper updates are usually folder based. e.g git reset HEAD^ + for-each-lib: {git add <lib wrapper> + git commit }. Some adjustment might be needed so that everything what belongs together should is in one commit, e.g test ng lib update commit should include all changes required to make that lib update work.

@ebarboni
ebarboni force-pushed the platformclusterlibupgrade branch from 62d7d2f to a9cdd73 Compare September 25, 2026 07:42
@ebarboni

Copy link
Copy Markdown
Contributor Author

@mbien done,

@ebarboni

Copy link
Copy Markdown
Contributor Author

As some check where in red I look a bit the log.

looks like compiler.flags entries in the test generated lots of warning
WARNING: Unknown module: jdk.compiler specified to --add-exports

Maybe continuing the ordering of some items could reduce the
WARNING: Not all children in / marked with the position attribute: with lots of items inside

@matthiasblaesing matthiasblaesing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@mbien mbien changed the title upgrade platform lib upgrade some commons libs, jsvg, junit and testng Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests for Ant projects no longer work with bundled TestNG libraries

3 participants