[test] Replace the removed MinIO test image with the pgsty/silo drop-in - #10167
Open
LuciferYang wants to merge 1 commit into
Open
LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
quay.io/minio/minio:RELEASE.2022-02-07T08-17-33Z is no longer pullable (MinIO archived its community edition and removed the images from Docker Hub and quay.io), so every MinioTestContainer user fails in CI with a testcontainers ContainerFetchException. Repoint DockerImageVersions.MINIO at pgsty/silo, a drop-in MinIO fork; the container config is unchanged. Follows grafana/mimir#16604.
Akash3121
approved these changes
Sep 24, 2026
Akash3121
left a comment
Akash3121
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The replacement preserves every contract used by both MinioTestContainer copies: server /data, MINIO_ROOT_USER, MINIO_ROOT_PASSWORD, port 9000, /minio/health/ready, S3 path-style access, and the STS flow. The exact Silo tag is active on Docker Hub with both linux/amd64 and linux/arm64 manifests. All 18 GitHub checks passed, including the full Java matrix and S3-backed tests; the PR remains at the reviewed head with no existing review comments or discussion.
Contributor
Author
|
cc @JingsongLi FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
quay.io/minio/minio:RELEASE.2022-02-07T08-17-33Z, pinned inDockerImageVersions.MINIO, is no longer pullable. MinIO archived its community edition and removed the images from Docker Hub (Sep 2026) and quay.io, soquay.io/minio/minionow returns 401 for an anonymous pull. Every test that starts the MinIO container (S3FileIOTestand the otherMinioTestContainerusers inpaimon-s3andpaimon-s3-impl) fails in CI withorg.testcontainers.containers.ContainerFetchException: Can't get Docker image.This repoints the pin at
pgsty/silo, a maintained community MinIO fork that keeps the S3 API, theMINIO_*env vars, the/minio/*routes, and the.minio.sysstorage layout, and still accepts the legacyserver <dir>argv. OnlyDockerImageVersions.MINIOchanges;MinioTestContainer(its command, env vars, and health probe) is untouched. This follows grafana/mimir#16604, which swapped to the same image and tag.pgsty/silois published on Docker Hub only, so the pin usesdocker.io.Tests
No new tests. The existing MinIO-backed tests (
S3FileIOTestand the otherMinioTestContainerusers) now pull an image that exists; the S3 CI jobs exercise the swap.API and Format
no
Documentation
no