Repository navigation
RANGER-5848: Add constraints to RangerAccessResult - #1320
Merged
Merged
Conversation
mneethiraj
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RANGER-5848: add constraints to
RangerAccessResult, so plugins and callers (such as the Agent Harness) can start integrating with constraint results before policy evaluation lands. This was split out of #1316 per review.Stacked on #1309 (RANGER-5838). Policy evaluation, which populates these constraints, follows in #1316 (RANGER-5842).
RangerConstraintResult (new)
Fields:
constraintName,parameters(copied on construction),policyId,policyVersion,policyPriority,matchType.CONSTRAINT_RESULT_COMPARATORorders by:RangerPolicyEvaluator's comparators, so OVERRIDE comes before NORMAL);This lets enforcement pick the applicable constraint.
RangerAccessResult
getConstraints()(returns an empty list when there are none),setConstraints()(copies the list) andaddConstraint().setAccessResultFrom()and cleared when the result becomes a deny (setIsAllowed(false)).toString().RangerBasePlugin
No behavior change: the policy engine doesn't populate constraints yet, so
getConstraints()is always empty until #1316.How was this patch tested?
New unit tests (8):
TestRangerConstraintResult:equals/hashCode/toStringincludepolicyPriority;TestRangerAccessResult:addConstraint(null)is ignored;setConstraints()copies the input list;setAccessResultFrom()copies constraints;mvn -pl agents-common checkstyle:check test